Fix reference

Signed-off-by: Jacob Woffenden <[email protected]>
ministryofjustice · Oct 5, 2023 · 194106a · 194106a
1 parent eb0f458
commit 194106a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/terraform/environments/data-platform/environment-configurations.tf b/terraform/environments/data-platform/environment-configurations.tf
@@ -2,23 +2,16 @@ locals {
   environment_configuration = local.environment_configurations[local.environment]
   environment_configurations = {
     development = {
-      apps_tools_account_id                    = local.environment_management.account_ids["data-platform-apps-and-tools-development"]
-      apps_tools_eks_oidc_url                  = "oidc.eks.eu-west-2.amazonaws.com/id/BEE86BED6494692D4ED31C2ED2319E13"
+      apps_tools_account_id = local.environment_management.account_ids["data-platform-apps-and-tools-development"]
     }
     test = {
-      // TODO: Replace with test values, keeping these as a placeholder
-      apps_tools_account_id                    = local.environment_management.account_ids["data-platform-apps-and-tools-development"]
-      apps_tools_eks_oidc_url                  = "oidc.eks.eu-west-2.amazonaws.com/id/BEE86BED6494692D4ED31C2ED2319E13"
+      apps_tools_account_id = local.environment_management.account_ids["data-platform-apps-and-tools-development"]
     }
     preproduction = {
-      // TODO: Replace with preproduction values, keeping these as a placeholder
-      apps_tools_account_id                    = local.environment_management.account_ids["data-platform-apps-and-tools-development"]
-      apps_tools_eks_oidc_url                  = "oidc.eks.eu-west-2.amazonaws.com/id/BEE86BED6494692D4ED31C2ED2319E13"
+      apps_tools_account_id = local.environment_management.account_ids["data-platform-apps-and-tools-development"]
     }
     production = {
-      // TODO: Replace with production values, keeping these as a placeholder
-      apps_tools_account_id                    = local.environment_management.account_ids["data-platform-apps-and-tools-development"]
-      apps_tools_eks_oidc_url                  = "oidc.eks.eu-west-2.amazonaws.com/id/BEE86BED6494692D4ED31C2ED2319E13"
+      apps_tools_account_id = local.environment_management.account_ids["data-platform-apps-and-tools-production"]
     }
   }
-}
+}
diff --git a/terraform/environments/data-platform/iam-roles.tf b/terraform/environments/data-platform/iam-roles.tf
@@ -7,7 +7,7 @@ module "openmetadata_iam_role" {
   role_name_prefix  = "openmetadata"
   role_requires_mfa = false
 
-  trusted_role_arns = ["arn:aws:iam::${local.apps_tools_account_id}:root"]
+  trusted_role_arns = ["arn:aws:iam::${local.environment_configuration.apps_tools_account_id}:root"]
 
   custom_role_policy_arns = [
     "arn:aws:iam::aws:policy/service-role/AWSQuicksightAthenaAccess",