API model updates #2267
Merged
API model updates #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![communityaccommodationtypegen[bot]](https://avatars.githubusercontent.com/u/2203574?s=60&v=4){kind=small}
communityaccommodationtypegen
bot
force-pushed
the
update-api-types
branch
2 times, most recently
from
96fb516 to
1f75689
Compare
communityaccommodationtypegen
bot
force-pushed
the
update-api-types
branch
from
1f75689 to
bce8f88
Compare
This updates the factory for a Space Search Premises Summary, which is renamed to match the new namespace and prevent confusion.
bobmeredith
reviewed
Jan 6, 2025
| @@ -41,7 +41,7 @@ describe('BookingsController', () => { | |||
| placementRequestService.getPlacementRequest.mockResolvedValue(placementRequestDetail) | |||
|
|
|||
| const query = { | |||
| bedSearchResult: encodeSpaceSearchResult(bedSearchResult), | |||
| bedSearchResult: encodeSpaceSearchResult(bedSearchResult as unknown as SpaceSearchResult), | |||
There was a problem hiding this comment.
This looks a bit odd to me - wouldn't the bedSearchResult be for the old search and SpaceSearchResult be the new one?
Ah, you mentioned in Slack - ignore me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating hmpps-approved-premises-api models from OpenAPI specification. This PR was created automatically from the generate-types.yml Workflow