Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update v2 manage integration test pages #1961

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

patrickjfl
Copy link
Contributor

@patrickjfl patrickjfl commented Jul 3, 2024

Changes in this PR

To tidy up the v2 code, I have removed the v2 integration test page files that don't sit within the v2 directory, and updated those that do.

This PR is currently blocked until this API PR is merged and the associated types have been updated in the UI.

Screenshots of UI changes

Before

After

@patrickjfl patrickjfl requested a review from edavey July 3, 2024 09:47
@patrickjfl patrickjfl force-pushed the chore/update-v2-manage-integration-test-pages branch 2 times, most recently from 5499904 to d060cfb Compare July 3, 2024 14:48
Copy link
Contributor

@edavey edavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tidying up

@patrickjfl patrickjfl force-pushed the chore/update-v2-manage-integration-test-pages branch 2 times, most recently from 59d816b to d060cfb Compare July 5, 2024 08:08
@patrickjfl patrickjfl force-pushed the chore/update-v2-manage-integration-test-pages branch from d060cfb to 600bf62 Compare July 5, 2024 08:16
@patrickjfl patrickjfl requested a review from richpjames July 5, 2024 08:53
@patrickjfl patrickjfl merged commit 123783b into main Jul 5, 2024
7 checks passed
@patrickjfl patrickjfl deleted the chore/update-v2-manage-integration-test-pages branch July 5, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants