Add CAS1 endpoints for departure, move on and non arrival reasons #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidatkinsuk
force-pushed
the
feature/aps-1756-add-cas1-ref-data-endpoints
branch
from
7edc475 to
ba75224
Compare
davidatkinsuk
changed the title
davidatkinsuk
force-pushed
the
feature/aps-1756-add-cas1-ref-data-endpoints
branch
2 times, most recently
from
6af7b22 to
5b3fd1c
Compare
vbala-moj
approved these changes
Jan 17, 2025
davidatkinsuk
force-pushed
the
feature/aps-1756-add-cas1-ref-data-endpoints
branch
from
5b3fd1c to
c02e91f
Compare
This should be used instead of the service-agnostic endpoint, which can return unexpected results due to the amiguous SQL being used (this is documented in this commit). Instead of ‘fixing’ the amiguous SQL and potentially disrupting CAS3, we’ve instead introduced a CAS1 specific version of the SQL/endpoint This commit also ‘splits’ a wildcarded departure reason to instead have CAS1 and CAS3 specific reasons. The existing reason was change to belong to CAS3 to avoid disrupting CAS3. This allows us to disable the reason for CAS1 without affecting CAS3
We also deprecate the ‘shared’ version of the endpoint, which is only used by CAS1 currently anyway
This should be used instead of the service-agnostic endpoint, which can return unexpected results due to the SQL being used. Instead of ‘fixing’ the SQL and potentially disrupting CAS3, we’ve instead introduced a CAS1 specific version.
davidatkinsuk
force-pushed
the
feature/aps-1756-add-cas1-ref-data-endpoints
branch
from
c02e91f to
6bfddc2
Compare
davidatkinsuk
deleted the
feature/aps-1756-add-cas1-ref-data-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also converts some wild-carded reasons into CAS-specific reasons, allowing us to disable them for CAS1 without affecting CAS3.