APS-1730 capture previous values on booking amend domain event #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidatkinsuk
force-pushed
the
feature/aps-1730-capture-previous-values-on-booking-amend-domain-event
branch
3 times, most recently
from
f9d7ef4 to
6a01c56
Compare
davidatkinsuk
changed the title
davidatkinsuk
force-pushed
the
feature/aps-1730-capture-previous-values-on-booking-amend-domain-event
branch
2 times, most recently
from
b80b564 to
a9c13c0
Compare
Moved private members to the bottom of the class for consistency
This commit updates the CAS1 booking changed domain event to capture the previous date values, if changed. It populates these values for booking changes.
davidatkinsuk
force-pushed
the
feature/aps-1730-capture-previous-values-on-booking-amend-domain-event
branch
from
a9c13c0 to
6d77f1b
Compare
daveawc
reviewed
Jan 3, 2025
| @Transactional | ||
| fun createDateChange( | ||
| booking: BookingEntity, | ||
| user: UserEntity, | ||
| newArrivalDate: LocalDate?, | ||
| newDepartureDate: LocalDate?, | ||
| ) = validated { | ||
| ) = validatedCasResult { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CAS1 booking changed domain event to capture the previous date values, if changed. It populates these values for booking changes.
This PR also adds a nullable characteristics and previousCharacteristics property to the domain event in preparation for recording space booking changes to characteristics