Cas2bail/spike1 #2671
Cas2bail/spike1 #2671
Conversation
garethCAS2
force-pushed
the
cas2bail/spike1
branch
from
00e0cdf to
b72f400
Compare
| private fun getApplicationOriginFromJpa(summary: Cas2ApplicationSummaryEntity): ApplicationOrigin { | ||
| return when { | ||
| summary.applicationOrigin == "bail" -> ApplicationOrigin.bail | ||
| else -> ApplicationOrigin.court |
There was a problem hiding this comment.
I think this should be else -> ApplicationOrigin.hdc as at this point it's which service is it coming from HDC or Bail
There was a problem hiding this comment.
would it be good to differentiate the bail types here also?
There was a problem hiding this comment.
Should this also be specific of bail or court - and error if it is neither?
|
As a proof of concept this looks good. It's nice and simple and we can see the steps involved in adding one field to the main application data. For anyone looking into the actual ApplicationOrigin data, this will still need to be considered |
| ApplicationOrigin: | ||
| type: string | ||
| enum: | ||
| - bail |
There was a problem hiding this comment.
as per previous comment - perhaps expand these to include hdc, and better differentiate the 2 types of bail e.g. prisonBail,courtBail,hdc ?
There was a problem hiding this comment.
agree - though lets use homeDetentionCurfew instead of hdc as it's clearer
This is the second method of adding bail support to the CAS2 application without duplicating the controller/service/entity.