-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor workflows to allow migration from ecr to ghcr and onto gihthub hosted runner #1398
base: main
Are you sure you want to change the base?
Conversation
…ics-platform-control-panel into migrate-to-ghcr
8ebcb77
to
e7cedf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see you've installed Docker Compose in GitHub Actions and are referencing it as docker-compose
but reference it as docker compose
in Makefile - Is this expected?
Can you ensure you add newlines to the end of files please
…ics-platform-control-panel into migrate-to-ghcr
…ics-platform-control-panel into migrate-to-ghcr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of very minor things, otherwise the changes look good.
However the main thing I wanted to check was, as this will change where the control panel images are stored, presumably the flux
repo will need updating to look for images in GHCR? Has this work been planned/ticketed? As I am unsure if there will be other changes required in that repo to give it permission to pull the images? And until that is completed, I dont think we will be able to deploy any new releases of Control Panel until flux is updated.
@@ -47,22 +47,22 @@ services: | |||
environment: | |||
DB_HOST: "db" | |||
DB_NAME: controlpanel | |||
DB_PASSWORD: password | |||
DB_PASSWORD: password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB_PASSWORD: password | |
DB_PASSWORD: password |
Seems to be some trailing whitespace that should be removed
AWS_REGION: ${AWS_REGION:-eu-west-1} | ||
AWS_SECRET_ACCESS_KEY: ${AWS_SECRET_ACCESS_KEY} | ||
AWS_SESSION_TOKEN: ${AWS_SESSION_TOKEN} | ||
DB_HOST: "db" | ||
DB_NAME: controlpanel | ||
DB_PASSWORD: password | ||
DB_PASSWORD: password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB_PASSWORD: password | |
DB_PASSWORD: password |
There is also a reference in the helm chart repo - presumably this would need updating also? https://github.com/ministryofjustice/analytics-platform-helm-charts/blob/65c233eed940527bb45c10469fd8473a07a66bda/charts/cpanel/values.yaml#L9 |
Discussed the above comments with the team on stand up 13/12/24 - decided not to merge this until we have addressed the above, so I have converted it to draft |
This Pull request is for the ticket -Make controlpanel ecr-repo public and push to GHCR
#6089
Which is part of the work for -Migrate jobs from github-actions-moj-CoFBZ3xV EKS Cluster
ministryofjustice/analytical-platform#4622
And will add the standard workflows amend the code to use GCHR and use GitHub Actions hosted runners
📚 Documentation status