feat: add dynamic s3Locations
statements to allow oidc roles access to specified s3 paths
#6567
+56
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Objective
This piece of work is being tracked in #4622.
#4622 involves switching over workflow processes to run on GitHub Actions runners assuming roles by OIDC (roles specified in the files edited in this PR) rather than running on self-hosted runners (see this PR for an example). In order to do this, the new OIDC roles need permissions to be able to carry out all of the duties of the existing roles.
A change is required to allow the
analytics-platform-helm-charts
role to deposit artefacts (which fails without this change) in s3. This is separate from the requirement for state bucket access, so a key:value pair was added to the oidc-roles json that creates a dynamic statement in thegithub_oidc_role
for each role.Checklist
and ensured that my code complies with it
used the
override-static-analysis
label, I've explained why)Additional Comments