Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cfodev 403 allow inductions phases to be added #257

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

carlsixsmith-moj
Copy link
Contributor

This is a recreation of the previous pull request because github got stuck

Copy link
Contributor

@PaulCooperWorkJustice PaulCooperWorkJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good especially with check changes

Hub inductions
Wing inductions
Phases

Add event for phase completion

This will support future work.

Changes as per peer review comment

Sort order of inductions
@carlsixsmith-moj
Copy link
Contributor Author

This can be merged now it's passed testing. @PaulCooperWorkJustice can you re-add your review

@carlsixsmith-moj carlsixsmith-moj enabled auto-merge (rebase) September 27, 2024 06:21
Copy link
Contributor

@PaulCooperWorkJustice PaulCooperWorkJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after rebase

@carlsixsmith-moj carlsixsmith-moj merged commit 31b257b into main Sep 27, 2024
1 check passed
@carlsixsmith-moj carlsixsmith-moj deleted the CFODEV-403-allow-inductions-phases-to-be-added branch September 27, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants