Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Source Link and Deterministic Builds #67

Open
wants to merge 7 commits into
base: 2.x
Choose a base branch
from

Conversation

henrygab
Copy link

@henrygab henrygab commented May 21, 2021

Fixes #67.

Supercedes PR #65.
Also partial fix for #54 (Enables automated GitHub Actions-based publishing).

I have validated using JustAssembly that the resulting assemblies are equivalent. All built-in tests continue to pass. Just the user experience is improved.

Three things are provided with this PR:

  1. Enabling of Source Link
  2. Enabling of deterministic builds when built via GitHub Actions
  3. Improvements to CLS-compliance (a few protected members were causing errors)

Source Link enables anyone building NuGet libraries to provide source-level debugging for their users with almost no effort. See also documentation.

Used NuGet Package Explorer to verify the package has Source Link enabled and is deterministic

Used JustAssembly with commit 0ce7ce4 to verify assemblies are identical to those published as minecraft-dotnet.Substrate v2.0.44-alpha.

henrygab added 5 commits May 21, 2021 13:32
    Improve CLS compliance
    Cleanup .csproj / assembly properties
    Support more platforms
    Use new project format
    Convert project to new .NET build
    add .NET 5.0 (.NET Core 5)
    Use expression to indicate MIT license
@henrygab
Copy link
Author

@jaquadro -- Are you doing any further work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant