Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of CI and ssd compatibility issue #782

Merged
merged 8 commits into from
Jun 12, 2024

Conversation

PingqiLi
Copy link
Contributor

@PingqiLi PingqiLi commented Jun 12, 2024

Thank you for your contribution to the MindCV repo.
Before submitting this PR, please make sure:

Motivation

This PR fixed 2 issues:

  1. The CI used to failed due to the test cases trying to download the MNIST dataset from a url which is no longer accessible.
  2. The ssd uses API of mindspore.MindDataset.project. It is defined as mindspore.dataset.Dataset.project(columns) in the most recent mindspore version. The previous PR wrongly used the parameter name as "output_columns".

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@PingqiLi PingqiLi marked this pull request as ready for review June 12, 2024 08:00
@geniuspatrick geniuspatrick merged commit 19c4a5b into mindspore-lab:main Jun 12, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants