Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[references] Update Logging #1847

Merged
merged 6 commits into from
Jan 23, 2025
Merged

[references] Update Logging #1847

merged 6 commits into from
Jan 23, 2025

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Jan 21, 2025 •
edited
Loading

This PR:

  • Small logging updates
  • Log train loss and lr also for each epoch
  • Progress bar show step val loss
  • Progress bar show lr changes on each step
  • Instead of print use tqdm to write / comes together with the tqdm logging

@felixdittrich92 felixdittrich92 self-assigned this Jan 21, 2025
@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Jan 21, 2025
@felixdittrich92 felixdittrich92 added type: enhancement Improvement ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition topic: character classification Related to the task of character classification labels Jan 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (ebfc9f3) to head (f7fb3e1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
+ Coverage   96.61%   96.62%   +0.01%     
==========================================
  Files         165      165              
  Lines        7941     7941              
==========================================
+ Hits         7672     7673       +1     
+ Misses        269      268       -1
Flag Coverage Δ
unittests 96.62% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 marked this pull request as ready for review January 21, 2025 11:14
odulcy-mindee
odulcy-mindee approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much ! 🥳
I saw you spotted few mistakes and typo as well, thanks !!

@felixdittrich92 felixdittrich92 merged commit d41ba35 into mindee:main Jan 23, 2025
69 of 70 checks passed
@felixdittrich92 felixdittrich92 deleted the logging-updates branch January 23, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

Assignees

@felixdittrich92 felixdittrich92

Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: character classification Related to the task of character classification topic: text detection Related to the task of text detection topic: text recognition Related to the task of text recognition type: enhancement Improvement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdittrich92 @odulcy-mindee