Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Replace mem leaking torch gaussian_blur in augmentations #1822

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Dec 18, 2024

This PR:

  • Replace mem leaking GaussianBlur augmentation and the functional used F.gaussian_blur with scipy
  • Add corresponding test for own GaussianBlur implementation
  • Adjust sigma range

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added type: bug Something isn't working ext: references Related to references folder module: transforms Related to doctr.transforms framework: pytorch Related to PyTorch backend labels Dec 18, 2024
@felixdittrich92 felixdittrich92 added this to the 0.11.0 milestone Dec 18, 2024
@felixdittrich92 felixdittrich92 self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (48873e0) to head (f9cadb7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1822      +/-   ##
==========================================
- Coverage   96.60%   96.59%   -0.01%     
==========================================
  Files         165      165              
  Lines        7929     7939      +10     
==========================================
+ Hits         7660     7669       +9     
- Misses        269      270       +1     
Flag Coverage Δ
unittests 96.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 merged commit 0e06eae into mindee:main Dec 18, 2024
69 of 70 checks passed
@felixdittrich92 felixdittrich92 deleted the augmentation-fix branch December 18, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend module: transforms Related to doctr.transforms type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants