Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds conda recipe & corresponding CI jobs #1414
feat: Adds conda recipe & corresponding CI jobs #1414
Changes from all commits
92b2d86
988ebed
8fb103c
c4868b9
fd9ce1a
dff533a
2c31fe0
64e381d
61a0758
3dea44e
6bb645c
92403c5
838f90d
17d07e2
1eca3ac
c08c2cd
ee0c273
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calling
setup.py
directly is deprecated, you'll want something likepython -m build --sdist
insteadsee also https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frgfm ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't know, thanks mara!
But for this PR, I don't think we need the edit:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for the time being. They might want to remove it after some deprecation period, but I don't know if they'll ever do, as this somehow doesn't seem to have reached the crowd at large.