Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitake/mitake php #6

Merged
merged 9 commits into from
Nov 26, 2021
Merged

Mitake/mitake php #6

merged 9 commits into from
Nov 26, 2021

Conversation

ywchang0612
Copy link
Contributor

目前我只實作了發送單一簡訊的 API 參考一下

@minchao
Copy link
Owner

minchao commented Nov 25, 2021

謝謝您。
發現 CI 似乎壞掉了,我來更新一下。

@minchao
Copy link
Owner

minchao commented Nov 25, 2021

@ywchang0612 只需要做一下 git rebase 到最新版本就可以執行 CI 測試囉。

@ywchang0612
Copy link
Contributor Author

@minchao 您是說用 master branch 發 PR 回來就會跑 CI 了嗎

@minchao
Copy link
Owner

minchao commented Nov 25, 2021

請隨意選擇使用 rebase 或 merge 來處理,例如:

  1. 請先將 forked repo ywchang0612/mitake-php 的 master 更新到 original 最新的 commit。
  2. 使用 rebase
    2.1. 在你的開發分支上執行 git rebase master,讓開發分支也跟上最新的 commit。
    2.2. 執行 git push --force 強制更新 remote 上的開發分支到最新狀態。
  3. 或是使用 merge
    3.1. 在你的開發分支上執行 git merge master 取得最新的更新。
    3..2. 執行 git push 更新 remote 上的開發分支。

@ywchang0612
Copy link
Contributor Author

@minchao 第一次發 PR ,還對整個流程沒有很熟~
感謝指導QQ

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #6 (fbe5288) into master (3a6f35c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
+ Coverage     99.38%   99.41%   +0.02%     
- Complexity      101      105       +4     
============================================
  Files            10       10              
  Lines           325      340      +15     
============================================
+ Hits            323      338      +15     
  Misses            2        2              
Impacted Files Coverage Δ
src/API.php 100.00% <100.00%> (ø)
src/Client.php 97.14% <100.00%> (ø)
src/Message/Message.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6f35c...fbe5288. Read the comment docs.

tests/ClientTest.php Outdated Show resolved Hide resolved
@@ -26,15 +26,15 @@
*/
class Client
{
const LIBRARY_VERSION = '0.3.0';
const LIBRARY_VERSION = '0.4.0';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考慮到新舊 API 端點的相容性,預期在完成新版的遷移後直接升級到 1.0.0。

@minchao minchao merged commit 911d4a8 into minchao:master Nov 26, 2021
@minchao
Copy link
Owner

minchao commented Nov 26, 2021

ref #5

@ywchang0612 ywchang0612 deleted the mitake/mitake-php branch December 7, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants