-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mitake/mitake php #6
Conversation
謝謝您。 |
@ywchang0612 只需要做一下 git rebase 到最新版本就可以執行 CI 測試囉。 |
@minchao 您是說用 master branch 發 PR 回來就會跑 CI 了嗎 |
請隨意選擇使用 rebase 或 merge 來處理,例如:
|
@minchao 第一次發 PR ,還對整個流程沒有很熟~ |
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
============================================
+ Coverage 99.38% 99.41% +0.02%
- Complexity 101 105 +4
============================================
Files 10 10
Lines 325 340 +15
============================================
+ Hits 323 338 +15
Misses 2 2
Continue to review full report at Codecov.
|
@@ -26,15 +26,15 @@ | |||
*/ | |||
class Client | |||
{ | |||
const LIBRARY_VERSION = '0.3.0'; | |||
const LIBRARY_VERSION = '0.4.0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
考慮到新舊 API 端點的相容性,預期在完成新版的遷移後直接升級到 1.0.0。
ref #5 |
目前我只實作了發送單一簡訊的 API 參考一下