test: test coverage for throwing Bandit plug call #17
Conversation
grzuy
changed the title
| # An exit instead of a throw because Bandit doesn't handle throw's | ||
| # for the moment. See: https://github.com/mtrudel/bandit/pull/396. | ||
| "class" => "(exit)", | ||
| "message" => "bad return value: \"from inside a plug\"", |
There was a problem hiding this comment.
After digging a bit deeper on why a throw within Bandit ends up being a "bad return value" exit, realized that it's because, given Bandit doesn't handle throws, and that the plug call runs inside a :gen_server, the thrown value gets interpreted as the :gen_server callback return value. See mtrudel/bandit#410.
So given that we're testing with throwing a string here, and that is an invalid :gen_server return value, we do get termination of the gen_server process and an exit event.
However, if the thrown value were to coincide with a valid :gen_server return value, no event would be raised. Extremely unlikely I guess, but technically possible.
| @@ -28,7 +28,7 @@ defmodule TowerHoneybadger.Honeybadger.Notice do | |||
| stacktrace: stacktrace, | |||
| plug_conn: plug_conn | |||
| }) do | |||
| error_notice("(exit)", reason, stacktrace, plug_conn) | |||
| error_notice("(exit)", Exception.format_exit(reason), stacktrace, plug_conn) | |||
There was a problem hiding this comment.
Moving this to a more generalized PR #18.
This shouldn't be a Bandit specific change.
grzuy
changed the title
grzuy
changed the title
No description provided.