Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties #198

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add properties #198

merged 1 commit into from
Oct 11, 2023

Conversation

xiaofan-luan
Copy link
Collaborator

@xiaofan-luan xiaofan-luan commented Oct 11, 2023

related to #199
Add property map in msgbase

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link

mergify bot commented Oct 11, 2023

@xiaofan-luan Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

Signed-off-by: xiaofan-luan <[email protected]>
@SimFG
Copy link
Collaborator

SimFG commented Oct 11, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit 5f3a9bd into milvus-io:master Oct 11, 2023
3 checks passed
SimFG added a commit that referenced this pull request Oct 16, 2023
* Add properties (#198)

Signed-off-by: xiaofan-luan <[email protected]>

* Add the VerifyAPIKey method in the hook interface (#197)

Signed-off-by: SimFG <[email protected]>

* Add the user return value for the VerifyAPIKey method

Signed-off-by: SimFG <[email protected]>

---------

Signed-off-by: xiaofan-luan <[email protected]>
Signed-off-by: SimFG <[email protected]>
Co-authored-by: Xiaofan <[email protected]>
SimFG pushed a commit to SimFG/milvus-proto that referenced this pull request Oct 18, 2023
SimFG added a commit that referenced this pull request Oct 18, 2023
* Add properties (#198)

Signed-off-by: xiaofan-luan <[email protected]>

* Add VerifyAPIKey method for the hook interface (#204)

Signed-off-by: SimFG <[email protected]>

---------

Signed-off-by: xiaofan-luan <[email protected]>
Signed-off-by: SimFG <[email protected]>
Co-authored-by: Xiaofan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants