Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix write_documents return value #20

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix write_documents return value #20

merged 1 commit into from
May 30, 2024

Conversation

lowener
Copy link
Contributor

@lowener lowener commented May 29, 2024

  • Add default search params for GPU indexes to avoid exceptions
  • Fix write_documents return value
  • Test write_documents return value

@mergify mergify bot added the dco-passed label May 29, 2024
zc277584121
zc277584121 reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@zc277584121 zc277584121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@zc277584121 zc277584121 merged commit 2964f40 into milvus-io:main May 30, 2024
3 of 4 checks passed
@lowener lowener deleted the fix-write branch May 30, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zc277584121 zc277584121 zc277584121 left review comments

Assignees
No one assigned
Labels
dco-passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lowener @zc277584121