Add a max brightness field for each dimmer in config file #149

README.md

@@ -106,6 +106,9 @@ The `defaults` has these properties:
 
 - `id` The name or id for the device that is registered in the Android/iOS App. When matching on ID please provide the `Tuya ID` as shown during Homebridge boot.
 - `device_type` The `device_type` to be overruled. This can be useful for dimmers that are reported as `light` by the Tuya API and don't support hue and saturation or for outlets that are reported as `switch`.
+- `max_brightness` The maximum value of your dimmer light brightness (It seems that not all dimmers has a the same value), you can get this value by setting your dimmer to 100% in Tuya\Smartlife app, then go into your homebridge main log screen and open the homekit app, once the accessories load you can view the output and see the current value of each light, this output value is your accessories maximum brightness.
+
+[14/02/2021, 19:26:34] [TuyaWebPlatform] [office light] Characteristic.Brightness - [GET] 255
 
 > Note: After overriding the device type, it might appear duplicated in both HomeBridge (Accessories Tab) and the Home App. To solve this issue, go to the Homebridge settings (top right corner) and remove the device using the `Remove Single Cached Accessory` option.
 

config.schema.json

@@ -78,6 +78,12 @@
               "description": "Can be found in your platform app (device info -> virtual ID) and is exposed during plugin boot (use the Tuya ID)",
               "required": true
             },
+            "max_brightness": {
+              "title": "The Device max brigthness",
+              "type": "number",
+              "default": "255",
+              "description": "Each dimmer light has different max value, find it and set it here"
+            },
             "device_type": {
               "title": "Device type",
               "type": "string",
@@ -260,6 +266,9 @@
             {
               "key": "defaults[].id"
             },
+            {
+              "key": "defaults[].max_brigthness"
+            },
             {
               "key": "defaults[].device_type"
             },

src/accessories/DimmerAccessory.ts

@@ -7,6 +7,7 @@ import {
   OnCharacteristic,
 } from "./characteristics";
 import { TuyaDevice } from "../api/response";
+import { TuyaDeviceDefaults } from "../config";
 
 export class DimmerAccessory extends BaseAccessory {
   constructor(
@@ -42,4 +43,19 @@ export class DimmerAccessory extends BaseAccessory {
 
     return super.deviceSupportedCharacteristics;
   }
+
+  validateConfigOverwrites(config: TuyaDeviceDefaults): string[] {
+    const errors = super.validateConfigOverwrites(config);
+    if (config?.max_brigthness) {
+      const maxBrigthness = Number(config.max_brigthness);
+      if (!maxBrigthness) {
+        errors.push(
+          "Wrong value configured for `max_brigthness`, should be a number"
+        );
+      } else {
+        config.max_brigthness = maxBrigthness;
+      }
+    }
+    return errors;
+  }
 }

src/accessories/LightAccessory.ts

@@ -11,6 +11,7 @@ import {
 } from "./characteristics";
 import { ColorAccessory } from "./ColorAccessory";
 import { TuyaDevice } from "../api/response";
+import { TuyaDeviceDefaults } from "../config";
 
 export class LightAccessory extends ColorAccessory {
   constructor(
@@ -59,4 +60,19 @@ export class LightAccessory extends ColorAccessory {
 
     return super.deviceSupportedCharacteristics;
   }
+
+  validateConfigOverwrites(config: TuyaDeviceDefaults): string[] {
+    const errors = super.validateConfigOverwrites(config);
+    if (config?.max_brigthness) {
+      const maxBrigthness = Number(config.max_brigthness);
+      if (!maxBrigthness) {
+        errors.push(
+          "Wrong value configured for `max_brigthness`, should be a number"
+        );
+      } else {
+        config.max_brigthness = maxBrigthness;
+      }
+    }
+    return errors;
+  }
 }

src/accessories/characteristics/brightness.ts

@@ -62,8 +62,10 @@ export class BrightnessCharacteristic extends TuyaWebCharacteristic {
       data?.color?.brightness !== undefined
     ) {
       stateValue = Number(data.color.brightness);
-    } else if (data?.brightness) {
-      stateValue = Math.round((Number(data.brightness) / 255) * 100);
+    } else if (data?.brightness && data?.max_brightness) {
+      stateValue = Math.round(
+        (Number(data.brightness) / data.max_brightness) * 100
+      );
     }
 
     if (stateValue) {

src/api/response.ts

@@ -4,6 +4,7 @@ import { TuyaDeviceDefaults } from "../config";
 export type ExtendedBoolean = boolean | "true" | "false" | "True" | "False";
 
 type TuyaProperties = Partial<{
+  max_brightness: number;
   brightness: number | string;
   color: Partial<{ hue: string; saturation: string; brightness: string }>;
   color_mode: ColorModes;

src/config.ts

@@ -5,6 +5,7 @@ import { TuyaDeviceType } from "./api/response";
 export type TuyaDeviceDefaults = {
   id: string;
   device_type: TuyaDeviceType;
+  max_brigthness: number;
   min_temper: string | number;
   max_temper: string | number;
   current_temperature_factor: string | number;