Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov.yml and configure codecov PR comments #97

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Feb 7, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f8bb9c1) 60.91% compared to head (0eea9d3) 60.89%.

Files Patch % Lines
milatools/cli/commands.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   60.91%   60.89%   -0.02%     
==========================================
  Files           9        9              
  Lines        1379     1381       +2     
==========================================
+ Hits          840      841       +1     
- Misses        539      540       +1     
Flag Coverage Δ
integrationtests 11.36% <0.00%> (-0.02%) ⬇️
unittests 60.89% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +386 to +389
def test_uncovered_code():
...


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a comment mentioning that it isn't covered. We'll have to wait until the codecov app is approved by IT to get them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants