-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with disk-quota
output parsing in mila code
#70
Conversation
Signed-off-by: Fabrice Normandin <[email protected]>
disk-quota
output parsingdisk-quota
output parsing in mila code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call to check_disk_quota
in code
should be wrapped in a try/catch, just to ensure that a breaking change (e.g. changing the filesystem) does not impede the functionality (since it is not strictly necessary in order for mila code
to work).
milatools/cli/commands.py
Outdated
```bash | ||
#!/bin/sh | ||
# (disk-quota) | ||
echo "==== HOME ====" | ||
lfs quota -h -u "${1:-$USER}" /home/mila | ||
|
||
echo "" | ||
echo "==== SCRATCH ====" | ||
beegfs-ctl --cfgFile=/etc/beegfs/scratch.d/beegfs-client.conf --getquota --uid "${1:-$USER}" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the content of the disk-quota
command, remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e3d7a90
milatools/cli/commands.py
Outdated
--------------|------||------------|------------||---------|--------- | ||
normandf|1471600598|| 97.20 GiB| 100.00 GiB|| 806898| 1000000 | ||
```bash | ||
$ lfs quota -h -u "${1:-$USER}" /home/mila |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not passing -h.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e3d7a90
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Fixed in caff6cf |
No description provided.