Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with disk-quota output parsing in mila code #70

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Nov 7, 2023

No description provided.

@lebrice lebrice requested a review from breuleux November 7, 2023 19:29
@lebrice lebrice changed the title Fix bug with outdated disk-quota output parsing Fix bug with disk-quota output parsing in mila code Nov 7, 2023
Copy link
Member

@breuleux breuleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to check_disk_quota in code should be wrapped in a try/catch, just to ensure that a breaking change (e.g. changing the filesystem) does not impede the functionality (since it is not strictly necessary in order for mila code to work).

Comment on lines 1038 to 1047
```bash
#!/bin/sh
# (disk-quota)
echo "==== HOME ===="
lfs quota -h -u "${1:-$USER}" /home/mila

echo ""
echo "==== SCRATCH ===="
beegfs-ctl --cfgFile=/etc/beegfs/scratch.d/beegfs-client.conf --getquota --uid "${1:-$USER}"
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the content of the disk-quota command, remove.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e3d7a90

--------------|------||------------|------------||---------|---------
normandf|1471600598|| 97.20 GiB| 100.00 GiB|| 806898| 1000000
```bash
$ lfs quota -h -u "${1:-$USER}" /home/mila
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not passing -h.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e3d7a90

@lebrice
Copy link
Collaborator Author

lebrice commented Nov 8, 2023

The call to check_disk_quota in code should be wrapped in a try/catch, just to ensure that a breaking change (e.g. changing the filesystem) does not impede the functionality (since it is not strictly necessary in order for mila code to work).

Fixed in caff6cf

@lebrice lebrice requested a review from breuleux November 8, 2023 17:21
@breuleux breuleux merged commit f238cf5 into mila-iqia:master Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants