Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with macOS in CI #120

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Apr 25, 2024

Fix some weird issue that seem to be related to using setup-python with cache: poetry on MacOS, for example here: https://github.com/mila-iqia/milatools/actions/runs/8834122225/job/24257059736?pr=112#step:4:53

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.98%. Comparing base (3a1237b) to head (eac9490).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #120       +/-   ##
===========================================
- Coverage   65.80%   44.98%   -20.82%     
===========================================
  Files          12       11        -1     
  Lines        1778     1776        -2     
===========================================
- Hits         1170      799      -371     
- Misses        608      977      +369     
Flag Coverage Δ
integrationtests ?
unittests 44.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice marked this pull request as ready for review April 25, 2024 20:14
@lebrice lebrice requested a review from breuleux April 25, 2024 20:20
@lebrice lebrice merged commit 320be40 into mila-iqia:master Apr 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants