Skip to content

Commit

Permalink
Fix test for make_process
Browse files Browse the repository at this point in the history
Signed-off-by: Fabrice Normandin <[email protected]>
  • Loading branch information
lebrice committed Apr 24, 2024
1 parent ae46a98 commit 5fb3dbe
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions tests/cli/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,5 @@ def test_get_fully_qualified_hostname_of_compute_node_unknown_cluster(
def test_make_process():
process = make_process(print, "hello", end="!")
assert isinstance(process, multiprocessing.Process)
# TODO: Make the process daemonic again (if needed), for now we want to be able to
# run the syncing of vscode extensions in the background during `mila code`.
assert not process.daemon
assert process.daemon
assert not process.is_alive()

0 comments on commit 5fb3dbe

Please sign in to comment.