Skip to content

Commit

Permalink
Add new bench to config file
Browse files Browse the repository at this point in the history
  • Loading branch information
pierre.delaunay committed Aug 15, 2024
1 parent 1c4d9a4 commit c0930cb
Show file tree
Hide file tree
Showing 46 changed files with 1,167 additions and 314 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ It will include all of the necessary data
docker run -it --rm --ipc=host --gpus=all \
-v $(pwd)/results:/milabench/envs/runs \
$MILABENCH_IMAGE \
milabench run
bash -c "milabench prepare && milabench run"

=================
Benchmark results
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/geo_gnn/requirements-pre.in
Original file line number Diff line number Diff line change
@@ -1 +1 @@
torch<2.4
torch
3 changes: 0 additions & 3 deletions benchmarks/geo_gnn/requirements.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@

--find-links https://data.pyg.org/whl/torch-2.3.0+cu121.html

voir>=0.2.17,<0.3
torch-geometric
torch-cluster
Expand Down
21 changes: 21 additions & 0 deletions benchmarks/llm/dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,27 @@ _llm:
method: per_gpu


llm-rlhf-single:
inherits: _llm
definition: .
install-variant: unpinned
plan:
method: per_gpu

argv:
"{milabench_code}/recipes/lora_finetune_single_device.py": true
--config: "{milabench_code}/configs/llama3_8B_lora_single_device.yaml"
epochs=1: true
output_dir={milabench_extra}/output: true
tokenizer.path={milabench_data}/llama3_8B/original/tokenizer.model: true
checkpointer.checkpoint_dir={milabench_data}/llama3_8B/original: true
checkpointer.output_dir={milabench_data}/llama3_8B/: true
metric_logger.log_dir={milabench_extra}/metrics: true
repo_id="meta-llama/Meta-Llama-3.1-8B": true
batch_size=8: true
gradient_accumulation_steps=8: true


llm-lora-single:
inherits: _llm
definition: .
Expand Down
1,084 changes: 1,084 additions & 0 deletions benchmarks/llm/recipes/ppo_full_finetune_single_device.py

Large diffs are not rendered by default.

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
31 changes: 0 additions & 31 deletions benchmarks/rlhf/Makefile

This file was deleted.

4 changes: 0 additions & 4 deletions benchmarks/rlhf/README.md

This file was deleted.

53 changes: 0 additions & 53 deletions benchmarks/rlhf/dev.yaml

This file was deleted.

126 changes: 0 additions & 126 deletions benchmarks/rlhf/main.py

This file was deleted.

5 changes: 0 additions & 5 deletions benchmarks/rlhf/requirements.in

This file was deleted.

38 changes: 0 additions & 38 deletions benchmarks/rlhf/voirfile.py

This file was deleted.

31 changes: 0 additions & 31 deletions benchmarks/torch_ppo_atari_envpool/benchfile.py

This file was deleted.

16 changes: 0 additions & 16 deletions benchmarks/torch_ppo_atari_envpool/prepare.py

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ endif

export MILABENCH_BASE

BENCH_NAME=torch_ppo_atari_envpool
BENCH_NAME=torchatari
MILABENCH_CONFIG=dev.yaml
MILABENCH_ARGS=--config $(MILABENCH_CONFIG) --base $(MILABENCH_BASE)

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from milabench.pack import Package


class Rlhf(Package):
class Torchatari(Package):
# Requirements file installed by install(). It can be empty or absent.
base_requirements = "requirements.in"

Expand All @@ -28,4 +28,4 @@ async def prepare(self):



__pack__ = Rlhf
__pack__ = Torchatari
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

torch_ppo_atari_envpool:
torchatari:
max_duration: 600
inherits: _defaults
definition: .
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading

0 comments on commit c0930cb

Please sign in to comment.