Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set encoding when opening README.rst #351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

isacarnekvist
Copy link

This is a problem when LC_ALL=C for example.

This is a problem when LC_ALL=C for example.
@rizar
Copy link
Contributor

rizar commented Apr 29, 2016

It does not seem to work with Python 2:

Processing /home/travis/build/mila-udem/fuel

    Complete output from command python setup.py egg_info:

    Traceback (most recent call last):

      File "<string>", line 1, in <module>

      File "/tmp/pip-mQKjA8-build/setup.py", line 9, in <module>

        with open(path.join(HERE, 'README.rst'), encoding='utf-8') as f:

    TypeError: 'encoding' is an invalid keyword argument for this function

@dwf
Copy link
Contributor

dwf commented Apr 29, 2016

io.open
https://stackoverflow.com/questions/10971033/backporting-python-3-openencoding-utf-8-to-python-2

On Fri, Apr 29, 2016 at 10:56 AM, Dzmitry Bahdanau <[email protected]

wrote:

It does not seem to work with Python 2:

Processing /home/travis/build/mila-udem/fuel

Complete output from command python setup.py egg_info:

Traceback (most recent call last):

  File "<string>", line 1, in <module>

  File "/tmp/pip-mQKjA8-build/setup.py", line 9, in <module>

    with open(path.join(HERE, 'README.rst'), encoding='utf-8') as f:

TypeError: 'encoding' is an invalid keyword argument for this function


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#351 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants