-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limiting the number of excursion in an iterator #177
base: master
Are you sure you want to change the base?
Conversation
Can you provide an example of where you might use this? It seems like most schemes provide a way to limit the number of returned batches/examples automatically based on their constructor arguments. |
When evaluating on the validation set I would like to use a random subset 2015-06-22 16:12 GMT-04:00 David Warde-Farley [email protected]:
|
Okay. The name could probably be better too -- it's unclear in what way it would be "limited". Perhaps "TruncatedEpochScheme"? @rizar might have an opinion. |
I'd be okay with |
"""Iterate over the sequence given an iterationScheme object | ||
but in a limited number of excursions defined by times | ||
""" | ||
def __init__(self, iteration_scheme, times, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can safely remove *args, **kwargs
. It's used in other iterators (e.g. ShuffledExampleScheme
) to pass arbitrary args and kwargs to the superclass' __init__
method, but in this case you're not calling any other __init__
method.
@mducoffe I'm doing a cleanup of the open PRs. Would you still like to go ahead with this one? |
No description provided.