Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor oct19 #86

Merged
merged 21 commits into from
Oct 21, 2024
Merged

Refactor oct19 #86

merged 21 commits into from
Oct 21, 2024

Conversation

rousseab
Copy link
Collaborator

@rousseab rousseab commented Oct 19, 2024

This PR joins together the code in PRs #83 and #84 and #85 to simplify review. These smaller PRs will be closed.

@rousseab rousseab requested a review from sblackburn86 October 19, 2024 11:14
Copy link
Collaborator

@sblackburn86 sblackburn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rousseab rousseab merged commit 3389c89 into main Oct 21, 2024
1 check passed
@rousseab rousseab deleted the refactor_oct19 branch October 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants