Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hikka Tracker Integration #1386

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

Lorg0n
Copy link

@Lorg0n Lorg0n commented Oct 26, 2024

Add Hikka tracker integration
Closes #1145

Add support for Hikka (https://hikka.io/), a Ukrainian online encyclopedia for manga and etc.

Changes implemented:

  • Added new Hikka tracker with ID 10
  • Implemented OAuth authentication flow with auto token refresh
  • Added full sync support for:
    • Reading status (Reading, Completed, On Hold, etc.)
    • Chapter progress
    • Scores (0-10 scale)
    • Manga search and linking
  • Created necessary data models and API integration
  • Added UI elements for tracker settings

All changes have been tested:

  • Authentication flow
  • Manga search and linking
  • Status/progress syncing
  • Error handling

Images

Settings Screen Manga Track Dialog
image image

@Smol-Ame
Copy link
Contributor

Include "Closes #1145" in your PR description to link to the feature request issue

@AntsyLich
Copy link
Member

How does the auth flow work for this site?

@Lorg0n
Copy link
Author

Lorg0n commented Oct 26, 2024

How does the auth flow work for this site?

I didn't mean anything special, just standard OAuth authorization.

@AntsyLich
Copy link
Member

Ok I was ambiguous. How does one create a oauth client or get the reference?

@Lorg0n
Copy link
Author

Lorg0n commented Oct 26, 2024

Ok I was ambiguous. How does one create a oauth client or get the reference?

https://hikka.io/settings/applications

@AntsyLich
Copy link
Member

Trying to create a new client I'm getting the error "Invalid field endpoint in request body"

@AntsyLich
Copy link
Member

Ok so the issue is with using the custom redirect url

@AntsyLich
Copy link
Member

Blocked by hikka-io/hikka#347

@Lorg0n
Copy link
Author

Lorg0n commented Oct 27, 2024

I'll redo the authorisation to work after the changes then

@Lorg0n
Copy link
Author

Lorg0n commented Oct 27, 2024

Okay, I changed the authorization. My local tests went fine
image

@Lorg0n
Copy link
Author

Lorg0n commented Oct 27, 2024

I don't understand why the test fails, even though everything is fine in my fork. I didn't touch MangaScreenModel.kt at all

@AntsyLich
Copy link
Member

AntsyLich commented Oct 27, 2024

Yeah ignore that bit. It passed lint previously but suddenly started to flag from today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hikka.io tracker support
3 participants