Add Dockerfile with hindent for easy use via Docker #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are Docker Hub hooks in the `hooks` folder to automatically build and push a Docker image with the given hindent version (for example, with a Docker Hub rule that triggers on Git tags). The Dockerfile can be tested with ``` scripts/test-docker ``` The Bash scripts have been linted with [ShellCheck](https://github.com/koalaman/shellcheck) as in ``` docker run --interactive --rm --volume "$(pwd):/mnt" \ koalaman/shellcheck:v0.7.1 \ hooks/build hooks/post_push scripts/test-docker ``` This addresses #571. A Docker Hub autobuild rule would need to be configured separately.
|
Thank you, and sorry for the delay in reviewing |
mihaimaruseac
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are Docker Hub hooks in the
hooksfolder to automatically build and push a Docker image with the given hindent version (for example, with a Docker Hub rule that triggers on Git tags).The Dockerfile can be tested with
The Bash scripts have been linted with ShellCheck as in
This addresses #571.
A Docker Hub autobuild rule would need to be configured separately. Example of a rule that would trigger on a Git tag push:
This build rule assumes that the package is uploaded to Hackage before the corresponding tag is pushed to GitHub, so that the triggered
stack install …in theDockerfilecan access the just uploaded package version.I can help configuring a Docker Hub repository
mihaimaruseac/hindent, but it should probably be owned by the same people as the code base.