Handle errors in passthrough test correctly #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-dinculescu
approved these changes
Dec 21, 2024
|
Thank you for pointing this out; it's a good catch. This issue is the same as the one that caused the error reported in #288. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Whilst experimenting with your library, I experienced a case where my lamp wasn't reachable over the network but the library printed that the passthrough protocol is supported.
The reason for this false assumption is the incorrect error handling of the
test_passthroughmethod. Currently, it's only checked whether the error case of the result is a tapo error but any other errors are ignored and handled as if the request succeeded.