Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chrono dependency #223

Closed
wants to merge 1 commit into from
Closed

Update chrono dependency #223

wants to merge 1 commit into from

Conversation

Michal-Szczepaniak
Copy link
Contributor

You're using Duration::try_minutes in for example t31x_result.rs but try_minutes wasn't introduced before version 0.4.34 of chrono

mihai-dinculescu
mihai-dinculescu requested changes Jun 3, 2024
View reviewed changes
Copy link
Owner

@mihai-dinculescu mihai-dinculescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, but why (re)add pyo3-asyncio?

@Michal-Szczepaniak
Copy link
Contributor Author

Idk maybe i messed up with conflict resolution

@mihai-dinculescu
Copy link
Owner

I've updated this as part of a bundle that updated multiple packages.
Thanks for raising it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihai-dinculescu mihai-dinculescu mihai-dinculescu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michal-Szczepaniak @mihai-dinculescu