Add luacheck.sh to automate checking all DFHack scripts. #1
Conversation
|
Hey, does it produce any useful result for DFHack scripts? I only developed it for Remote scripts and added features I needed there. Also, did you find all types of annotations it supports? |
|
I'm working on it for this PR: DFHack/dfhack#1295 It's already found a few problems with typo'd variable and function names. |
index.js
Outdated
| var m = modules[call.arguments[0].value]; | ||
| if (!m) { | ||
| m = modules[call.arguments[0].value] = { _type:'table', _module:ctx }; | ||
| if (call.arguments[0].value == 'plugins.eventful') { |
There was a problem hiding this comment.
Any way not to hardcode all this here?
There was a problem hiding this comment.
gonna move this to builtins_basic.js
index.js
Outdated
| var found = false; | ||
| if (base && base._defclass && member) { | ||
| for (var p = base; p; p = p._super) { | ||
| if (p._type == 'Screen' && (member == 'onShow' || member == 'onDismiss' || member == 'onDestroy' || member == 'onRender' || member == 'onIdle' || member == 'onHelp' || member == 'onGetSelectedUnit' || member == 'onGetSelectedItem' || member == 'onGetSelectedJob' || member == 'onGetSelectedBuilding')) { |
There was a problem hiding this comment.
And this ideally shouldn't be hardcoded right in process() either.
There was a problem hiding this comment.
I have an anyfunc:none type that would work for this one, and the others can do similar things. I can also remove the __gui_Painter type alias.
No description provided.