Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: Remove agent configuration #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Jul 13, 2018

To avoid fragile dependencies among components.
Also, having those setting hardcoded here makes TEMPLATE
setting in agent less useful.
The default setting should be good enough for now.

Signed-off-by: YAMAMOTO Takashi [email protected]

To avoid fragile dependencies among components.
Also, having those setting hardcoded here makes TEMPLATE
setting in agent less useful.
The default setting should be good enough for now.

Signed-off-by: YAMAMOTO Takashi <[email protected]>
@maht
Copy link
Contributor

maht commented Jul 13, 2018

It looks ok to me, but since currently it is not possible to launch a CI gate job from a pull request some time is needed to test it, unless you have already done it and it is safe to merge right now.

@yamt
Copy link
Contributor Author

yamt commented Jul 13, 2018

i haven't tested at all.

@maht
Copy link
Contributor

maht commented Jul 13, 2018

Testing it at midonet_kubernetes_e2e/197

@yamt
Copy link
Contributor Author

yamt commented Jul 17, 2018

i tested this locally and it seemed working.

@yamt
Copy link
Contributor Author

yamt commented Jul 17, 2018

it seems that midonet_kubernetes_e2e/197 failed to start midonet cluster. can the job be re-run with "Rebuild" menu? i'm not sure how the job was created.

("midonet_kubernetes_e2e/197" is a job in midokura-private CI.
http://jenkins.midokura.com/job/iessp/job/iaas/job/kubernetes/job/midonet_kubernetes_e2e/197/ )

@maht
Copy link
Contributor

maht commented Jul 17, 2018

It can be rebuilt, but it depends on artifacts generated by other jobs executions that are no longer available. I will launch again selecting an available execution to provide the artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants