Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle facebook limited login #113

Merged
merged 8 commits into from
Jan 8, 2025
+160 −45
Merged

Handle facebook limited login #113

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6157751
Handle facebook limited login
carlosvstokkur Aug 28, 2024
46375ea
PR Fixes
carlosvstokkur Aug 30, 2024
3a6573a
Merge remote-tracking branch 'origin/master' into facebook-limited-login
vthorsteinsson Jan 3, 2025
e493b12
Modified caching; other small changes
vthorsteinsson Jan 3, 2025
43a3107
Add user ID validation for Facebook OAuth token
carlosvstokkur Jan 7, 2025
f4870bc
Refactor Facebook OAuth token validation and return public key correctly
carlosvstokkur Jan 8, 2025
159c157
Formatting; token verification for Facebook limited login
vthorsteinsson Jan 8, 2025
8013a78
Merge remote-tracking branch 'origin/master' into facebook-limited-login
vthorsteinsson Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,11 @@ def oauth_fb(request: Request) -> ResponseType:
),
401,
)
if account != user.get("id"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me like we need instead, in line 386, something like this:

account_in_token = decoded_token.get("sub", "")
if account_in_token != account:
    return (jsonify(...), 401)  # User account mismatch

We already assigned the account variable in line 326 and the user id in the token ("sub") must match that account id.

return (
jsonify({"status": "invalid", "msg": "Wrong user id in Facebook token"}),
401,
)
else:
# Validate regular Facebook token
r = requests.get(
Expand Down