Enganga/fix typemismatch issue #1214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1194) * Sub-Modules as RequiredModules * Sub-Modules as RequiredModules * Sub-Modules as RequiredModules * Sub-Modules as RequiredModules * Sub-Modules as RequiredModules * Sub-Modules as RequiredModules
|
Learn Build status updates of commit 1c0b2e9: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 6743d62: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit bf47e72: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit f6f42d2: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
KenitoInc
requested changes
Nov 18, 2024
| @@ -31,7 +31,7 @@ BeforeAll { | |||
| Describe "Add-EntraBetaScopedRoleMembership" { | |||
| Context "Test for Add-EntraBetaScopedRoleMembership" { | |||
| It "Should add a user to the specified role within the specified administrative unit" { | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.AzureAD.Model.RoleMemberInfo | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.MSGraph.Model.MsRoleMemberInfo | |||
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |||
There was a problem hiding this comment.
Suggested change
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |
| $RoleMember.Id = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" |
| @@ -42,7 +42,7 @@ Describe "Add-EntraBetaScopedRoleMembership" { | |||
| Should -Invoke -CommandName New-MgBetaDirectoryAdministrativeUnitScopedRoleMember -ModuleName Microsoft.Graph.Entra.Beta.DirectoryManagement -Times 1 | |||
| } | |||
| It "Should add a user to the specified role within the specified administrative unit with alias" { | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.AzureAD.Model.RoleMemberInfo | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.MSGraph.Model.MsRoleMemberInfo | |||
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |||
There was a problem hiding this comment.
Suggested change
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |
| $RoleMember.Id = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" |
| @@ -71,7 +71,7 @@ Describe "Add-EntraBetaScopedRoleMembership" { | |||
| { Add-EntraBetaScopedRoleMembership -AdministrativeUnitId "0e3840ee-40b6-4b72-827b-c06e1f59d2be" -RoleMemberInfo "" } | Should -Throw "Cannot process argument transformation on parameter 'RoleMemberInfo'*" | |||
| } | |||
| It "Result should contain Alias properties"{ | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.AzureAD.Model.RoleMemberInfo | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.MSGraph.Model.MsRoleMemberInfo | |||
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |||
There was a problem hiding this comment.
Suggested change
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |
| $RoleMember.Id = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" |
| @@ -91,7 +91,7 @@ Describe "Add-EntraBetaScopedRoleMembership" { | |||
| $params.AdministrativeUnitId1 | Should -Be "0e3840ee-40b6-4b72-827b-c06e1f59d2be" | |||
| } | |||
| It "Should contain RoleId in parameters when passed RoleObjectId to it" { | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.AzureAD.Model.RoleMemberInfo | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.MSGraph.Model.MsRoleMemberInfo | |||
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |||
There was a problem hiding this comment.
Suggested change
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |
| $RoleMember.Id = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" |
| @@ -101,7 +101,7 @@ Describe "Add-EntraBetaScopedRoleMembership" { | |||
| It "Should contain 'User-Agent' header" { | |||
| $userAgentHeaderValue = "PowerShell/$psVersion EntraPowershell/$entraVersion Add-EntraBetaScopedRoleMembership" | |||
| $userAgentHeaderValue = "PowerShell/$psVersion EntraPowershell/$entraVersion Add-EntraBetaScopedRoleMembership" | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.AzureAD.Model.RoleMemberInfo | |||
| $RoleMember = New-Object -TypeName Microsoft.Open.MSGraph.Model.MsRoleMemberInfo | |||
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |||
There was a problem hiding this comment.
Suggested change
| $RoleMember.ObjectId = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" | |
| $RoleMember.Id = "a23541ee-4fe9-4cf2-b628-102ebaef8f7e" |
KenitoInc
force-pushed
the
modularize
branch
from
e6ba625
to
0fff351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.