Fix NamedType generation in MATLAB codegen #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstairs
reviewed
Dec 13, 2024
johnstairs
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in MATLAB codegen that was found when implementing tools in MATLAB for the PETSIRD model.
Previously, most
NamedTypeswere implemented in MATLAB as a function returning an instance of the underlying type, since MATLAB does not support type aliasing. This approach doesn't work when attempting to create vectors or arrays of theNamedType. The PETSIRD model contains vectors of aliasedRecordtypes, which uncovered the bug.Now, we no longer generate any MATLAB code for
NamedTypesthat alias strings, vectors, or arrays. Records, unions, and optionalNamedTypesare implemented using subclassing. Yardl maps are now implemented as a MATLAByardl.Mapclass, which wraps thedictionarytype.