Return error if config override is invalid

microsoft · Oct 4, 2024 · cd113f7 · cd113f7
1 parent 4ad3510
commit cd113f7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tooling/internal/cmd/configargs.go b/tooling/internal/cmd/configargs.go
@@ -22,7 +22,7 @@ func updatePackageInfoFromArgs(packageInfo *packaging.PackageInfo, configArgs ma
 			log.Info().Msgf("Overriding config key %s with value %s", key, value)
 			k.Set(key, value)
 		} else {
-			log.Info().Msgf("Ignoring invalid config key %s", key)
+			return fmt.Errorf("invalid config key %s", key)
 		}
 	}
 

diff --git a/tooling/internal/cmd/validatecommand.go b/tooling/internal/cmd/validatecommand.go
@@ -29,7 +29,7 @@ func newValidateCommand() *cobra.Command {
 
 			warnings, err := validateImpl(configOverrides)
 			if err != nil {
-				fmt.Fprintln(os.Stderr, err)
+				log.Error().Msg(err.Error())
 				os.Exit(1)
 			}
 			for _, warning := range warnings {