Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Unexpected scopes when grammar is embedded in HTML grammar #112189 #113434

Closed
wants to merge 1 commit into from
Closed

Conversation

rahul3v
Copy link

@rahul3v rahul3v commented Dec 26, 2020

Works fine now for both single and double quotes
Will fix the issue #112189

Also submitted the PR to textmate/html.tmbundle

Currently :

earlierInlineJs

After change :

InlineJs



Works fine now for both single and double quotes
Will fix the issue #112189

Also submitted the PR to `textmate/html.tmbundle`
@aeschli
Copy link
Contributor

aeschli commented Jan 5, 2021

Thanks for the contribution. However, the change needs to go to https://github.com/textmate/html.tmbundle.

See the file header:

	"information_for_contributors": [
		"This file has been converted from https://github.com/textmate/html.tmbundle/blob/master/Syntaxes/HTML.plist",
		"If you want to provide a fix or improvement, please create a pull request against the original repository.",
		"Once accepted there, we are happy to receive an update request."
	],

@aeschli aeschli closed this Jan 5, 2021
@rahul3v
Copy link
Author

rahul3v commented Jan 6, 2021

well @aeschli , I do have requested PR for that at textmate, but that repository didn't finalize the PR yet, and last PR at that repository was closed very long time ago, like almost 1 year before to be specific.

@aeschli aeschli assigned alexr00 and unassigned aeschli Jan 6, 2021
@alexr00
Copy link
Member

alexr00 commented Jan 6, 2021

@rahul3v we can't be experts in every language on a team of our size, which is why we rely on the community for the grammars we use. I am open to the idea of moving away from the grammar we get from https://github.com/textmate/html.tmbundle if there is a better/better supported one.

@rahul3v
Copy link
Author

rahul3v commented Jan 6, 2021

well @alexr00 I can understand that, I do have made a PR, lets see,
otherwise you can have it tasted before merging this PR , as I have directly tested the changes I made on my installed VSCODE Editor (using current version 1.52.1) and it works fine for me. as you can also see it in the images above

The issue occur for both // and /* when using, which will fix with this PR

@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants