Unexpected scopes when grammar is embedded in HTML grammar.

[alexr00]

TS and JS Grammar Extension version: 0.0.55 / latest

When embedding the grammar in another grammar (HTML) there is unexpected behavior. The scope of the : is odd. The same onclick handler in a js file does not have this problem.

Code

<input type="button" onclick="window.location.href='https://vismaya.us/"

Originally from @vismodo in #111394

[sheetalkamat]

@mjbvz this seems like vscode issue and not grammar issue.
I dont have permissions to tranfer issue to vscode

[vismodo]

If I am not wrong, I think the correct syntax for an input is:

The same happens even with the correct syntax. The https is in a different color too. Only that the = inside the onclick parameter is white in color. I use the default Visual Studio Dark theme with no extension that may affect JavaScript or HTML.

[mjbvz]

The string seems to be getting split into two parts: 'http: and then //vismaya. The second part is parsed as a comment

Not sure why this is happening and I haven't been able to repo it in a normal JS file yet

[mjbvz]

@alexr00 I believe this line may be to blame:

vscode/extensions/html/syntaxes/html.tmLanguage.json

Line 225 in 18bab62

"match": "([^\\n\"/]|/(?![/*]))+"

Specifically, the match rule: ([^\\n\"/]|/(?![/*]))+ seems to stop parsing if // appears anywhere in the JS, even inside of a string

[alexr00]

Thanks @mjbvz for looking! Marking issue as upstream: textmate/html.tmbundle#113