Discover Gradle builds by looking for setting.gradle(.kts) #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the option 'gradle.nestedProjects: true' is set, the build roots are currently discovered by looking for the wrapper scripts. These however are completely optional for a build. But there is one thing each Gradle build definitely needs to have: A 'settings.gradle' or 'setting.gradle.kts' file. Gradle itself searches for these files to accept a folder as a Gradle build/project. This change proposes to check for these files instead of the gradlw scripts. A good project to test this with is https://github.com/microsoft/build-server-for-gradle which contains a lot of Gradle build in the 'testProjects' folder. Signed-off-by: Jendrik Johannes <[email protected]>
|
Ops, some tests failed. Let me check what's happening |
jdneo
force-pushed
the
discover-gradle-builds-by-settings
branch
from
70c9b8b to
d599e1c
Compare
jdneo
force-pushed
the
discover-gradle-builds-by-settings
branch
from
d599e1c to
9157777
Compare
jdneo
approved these changes
Oct 24, 2024
|
Thank you @jjohannes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the option
gradle.nestedProjects: trueis set, the build roots are currently discovered by looking for the wrapper scripts. These however are completely optional for a build.But there is one thing each Gradle build definitely needs to have: A
settings.gradleorsetting.gradle.ktsfile.Gradle itself searches for these files to accept a folder as a Gradle build/project.
This change proposes to check for these files instead of the gradlw scripts.
A good project to test this with is
https://github.com/microsoft/build-server-for-gradle which contains a lot of Gradle builds in the
testProjectsfolder.