fix: comments

microsoft · Aug 2, 2024 · 175c8b9 · 175c8b9
1 parent 50128b8
commit 175c8b9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/extension/src/bs/BspProxy.ts b/extension/src/bs/BspProxy.ts
@@ -55,10 +55,7 @@ export class BspProxy {
         importerConnection: rpc.MessageConnection | null,
         buildServerConnection: rpc.MessageConnection | null
     ): void {
-        if (!importerConnection) {
-            return;
-        }
-        if (!buildServerConnection) {
+        if (!importerConnection || !buildServerConnection) {
             return;
         }
         importerConnection.onRequest((method, params) => {

diff --git a/extension/src/server/GradleServer.ts b/extension/src/server/GradleServer.ts
@@ -49,11 +49,16 @@ export class GradleServer {
         return this.languageServerPipePath;
     }
     public async start(): Promise<void> {
-        const isPrepared = this.bspProxy.prepareToStart();
-        if (!isPrepared) {
-            this.logger.error("Failed to generate build server pipe path, build server will not start");
+        let startBuildServer = false;
+        if (redHatJavaInstalled()) {
+            const isPrepared = this.bspProxy.prepareToStart();
+            if (isPrepared) {
+                startBuildServer = true;
+            } else {
+                this.logger.error("Failed to generate build server pipe path, build server will not start");
+            }
         }
-        const startBuildServer = isPrepared && redHatJavaInstalled();
+
         this.bspProxy.setBuildServerStarted(startBuildServer);
 
         this.taskServerPort = await getPort();