qtbase: don't require pcre2's default features #42321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
MonicaLiu0311
added
the
category:port-feature
MonicaLiu0311
approved these changes
Nov 25, 2024
MonicaLiu0311
added
the
info:reviewed
|
Thanks! |
Osyotr
reviewed
Nov 26, 2024
| @@ -10,7 +11,10 @@ | |||
| "name": "libb2", | |||
| "platform": "!windows" | |||
| }, | |||
| "pcre2", | |||
There was a problem hiding this comment.
It seems kinda odd that qtbase depends on pcre2 but also have a separate feature for it.
There was a problem hiding this comment.
Yes that seemed weird to me too. I left it as-is because I figured there must have been a reason it was done like that, but if usage of PCRE2 is a feature that is supposed to be disable-able, then it should probably be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply changes the
pcre2dependency ofqtbaseto not enable the default features. I need to be able to disable them in a project's manifest file, andqtbasenot declaring that it doesn't need them is preventing me from doing this.