[libavif] Fix usage requirements export #42250
Conversation
MonicaLiu0311
added
the
category:port-bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
CI still doesn't start @BillyONeal. |
|
Yeah, something is broken. Having difficulty trying to restore it due to the storm damage last night https://www.seattletimes.com/seattle-news/weather/bomb-cyclone-over-450000-people-without-power-in-western-washington/ |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I destroyed and recreated all the pools and that seems to have fixed it for now, macs will be slow until I wake them all back up since that is a manual process. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
:sigh: One more time |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MonicaLiu0311
added
the
info:reviewed
| + install(EXPORT ${PROJECT_NAME}-config DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME} FILE ${PROJECT_NAME}-targets.cmake) | ||
| + if(NOT BUILD_SHARED_LIBS) | ||
| + target_include_directories(avif_static PUBLIC $<INSTALL_INTERFACE:include>) | ||
| + set(avif_static_link_libs yuv) |
There was a problem hiding this comment.
Stupid question: Why is this yuv rather than yuv::yuv like above?
There was a problem hiding this comment.
This port is taking separate paths for static vs. dynamic linkage.
yuv::yuv is from libavif's find module, used to link the shared libavif lib. No transitive usage requirements.
This PR just adds dependencies to take effect downstream when linking the static lib. yuv is vcpkg's unofficial target provided by find_dependency(libyuv CONFIG).
There was a problem hiding this comment.
(It is very hard to merge the separate paths. The static lib is merged with custom commands instead using plain cmake.)
Amends #41569.
Fixes #42112.
Alternative to #42151.