[spatial-hash] add new port #42197
Merged
[spatial-hash] add new port #42197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Nov 17, 2024
FrankXie05
added
the
category:new-port
FrankXie05
requested changes
Nov 18, 2024
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". |
FrankXie05
previously approved these changes
Nov 19, 2024
|
The usage has been tested successfully on |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
reviewed
Nov 20, 2024
Comment on lines
8
to
12
| -find_dependency(Eigen3 REQUIRED) | ||
| -find_package(PkgConfig REQUIRED) | ||
| -pkg_check_modules(glog REQUIRED IMPORTED_TARGET libglog) | ||
| - | ||
| +find_package(Eigen3 REQUIRED) |
There was a problem hiding this comment.
find_dependency was correct before
BillyONeal
reviewed
Nov 20, 2024
BillyONeal
reviewed
Nov 20, 2024
BillyONeal
reviewed
Nov 20, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@FrankXie05 @BillyONeal |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Sorry, been a hectic couple of days. Power has been out for me since Tuesday night |
|
There is no problem, but there seems to be a problem with azure bot. |
|
yuppi :) done :) . |
|
Is there anything I should do? |
|
Thanks for confirming that the DLL edge cases work out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes comply with the maintainer guide.
The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.The versioning scheme in
vcpkg.jsonmatches what upstream says.The license declaration in
vcpkg.jsonmatches what upstream says.The installed as the "copyright" file matches what upstream says.
The source code of the component installed comes from an authoritative source.
The generated "usage text" is accurate. See adding-usage for context.
Only one version is in the new port's versions file.
Only one version is added to each modified port's versions file.
I'm not sure I understand this question. So I don't know what the answer should be.