-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kealib] Cleanup, fix CMake config #35461
Conversation
@@ -4,7 +4,9 @@ vcpkg_from_github( | |||
REF "kealib-${VERSION}" | |||
SHA512 82399f1332ff2aeb6342732e9e5c897c813109fd18e77cfc8d866f06adf4faa7f080f1f3c0a3b777fb3a679912dacf4851b7ad09a338d6087dd1d26eb2d1689f | |||
HEAD_REF master | |||
PATCHES hdf5_include.patch | |||
PATCHES | |||
kealib-target.diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -4,7 +4,9 @@ vcpkg_from_github( | |||
REF "kealib-${VERSION}" | |||
SHA512 82399f1332ff2aeb6342732e9e5c897c813109fd18e77cfc8d866f06adf4faa7f080f1f3c0a3b777fb3a679912dacf4851b7ad09a338d6087dd1d26eb2d1689f | |||
HEAD_REF master | |||
PATCHES hdf5_include.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointless patch.
When testing usage, the following error occurs:
test.cpp#include <iostream> #include "libkea/KEACommon.h" CMakeLists.txtcmake_minimum_required (VERSION 3.8) |
@MonicaLiu0311 Please review again. |
The usage test passed on |
Thanks for the fix! |
Cherry-picked from #35437.