Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libtins] Fix include header file cannot be found #34461

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

jimwang118
Copy link
Contributor

Fixes #34440
fatal error: 'tins/tins.h' file not found

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 13, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Oct 13, 2023

Could you check which other changes are needed (upstream) to get rid of the specific cmake config fixup in the portfile?

I also notice that the pc file doesn't provide the right Cflags for making the documented #include <tins/tins.h> work.

@jimwang118
Copy link
Contributor Author

Could you check which other changes are needed (upstream) to get rid of the specific cmake config fixup in the portfile?

I also notice that the pc file doesn't provide the right Cflags for making the documented #include <tins/tins.h> work.

Cflags in the pc file has an extra layer of directory tins, so use #include <tins.h> to find the header file. Does this need fixing?

@dg0yt
Copy link
Contributor

dg0yt commented Oct 13, 2023

I think the inconsistency between pc file and documentation needs to be raised upstream.

@jimwang118
Copy link
Contributor Author

jimwang118 commented Oct 13, 2023

I think the inconsistency between pc file and documentation needs to be raised upstream.

I have reported the fix to upstream via PR 517.

Could you check which other changes are needed (upstream) to get rid of the specific cmake config fixup in the portfile?

Does this require me to modify anything else?

@jimwang118 jimwang118 marked this pull request as ready for review October 13, 2023 07:16
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Oct 13, 2023
@BillyONeal BillyONeal merged commit 4029389 into microsoft:master Oct 13, 2023
15 checks passed
@BillyONeal
Copy link
Member

Thanks!

clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libtins library has no INTERFACE_INCLUDE_DIRECTORIES target property.
4 participants