[ccd] Add emscripten support #11407
Merged
[ccd] Add emscripten support #11407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport upstream patch: danfis/libccd#70 Disable BUILD_TESTING, that has also the nice side effect of a faster build on all triplets.
NancyLi1013
approved these changes
May 18, 2020
|
Hi @traversaro |
In this specific case, I am not sure if this is a good idea. The upstream maintainer of libccd is not active in this days, and he is not merging even bug fix such as danfis/libccd#56 . For this reason I am afraid that if we wait for upstream, I am not sure if this PR will ever be merged. |
|
@traversaro |
NancyLi1013
added
the
category:port-feature
JangBoo
pushed a commit
to JangBoo/vcpkg
that referenced
this pull request
Jun 18, 2020
Backport upstream patch: danfis/libccd#70 Disable BUILD_TESTING, that has also the nice side effect of a faster build on all triplets.
penumbra23
pushed a commit
to codespace-dev/vcpkg
that referenced
this pull request
Aug 5, 2020
Backport upstream patch: danfis/libccd#70 Disable BUILD_TESTING, that has also the nice side effect of a faster build on all triplets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport upstream patch: danfis/libccd#70
Disable BUILD_TESTING, that has also the nice side effect of a faster build on all triplets.
What does your PR fix? This PR fixes compilation of the ccd port on custom triplets that use Emscripten.
Which triplets are supported/not supported? Have you updated the CI baseline? The CI baseline should not be affected.
Does your PR follow the maintainer guide? Yes.