Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UIMarkdown with AuditMode #18221

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Fix UIMarkdown with AuditMode #18221

merged 4 commits into from
Nov 25, 2024

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Nov 20, 2024 •
edited by DHowett
Loading

Adds the UIMarkdown library to AuditMode

lhecker
lhecker reviewed Nov 22, 2024
View reviewed changes
src/cascadia/UIMarkdown/MarkdownToXaml.cpp Outdated Show resolved Hide resolved
src/inc/til/winrt.h Outdated Show resolved Hide resolved
src/inc/til/winrt.h Outdated Show resolved Hide resolved
@DHowett DHowett added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Terminal The new Windows Terminal. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. and removed Area-Build Issues pertaining to the build system, CI, infrastructure, meta labels Nov 25, 2024
carlos-zamora
carlos-zamora approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOO!

@lhecker lhecker added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 25, 2024
@DHowett DHowett merged commit 184dfdc into main Nov 25, 2024
20 checks passed
@DHowett DHowett deleted the dev/pabhoj/markdown_audit_mode branch November 25, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PankajBhojwani @DHowett @lhecker @carlos-zamora