Add Warnings to Settings UI #17933
Merged
Add Warnings to Settings UI #17933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
I kinda dislike that they all start with "Warn when...", but at the same time, it's very clear what they'll do. Replacing it with "Warning: ", for example, isn't as clear. Any suggestions? |
lhecker
reviewed
Sep 23, 2024
lhecker
approved these changes
Sep 24, 2024
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
lhecker
approved these changes
Sep 25, 2024
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
DHowett and
lhecker
PankajBhojwani
approved these changes
Sep 25, 2024
microsoft-github-policy-service
bot
removed
the
Needs-Second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following settings to the Interaction page under a Warnings subsection:
This also changes the JSON keys of those settings to be in the
warningnamespace as a QOL change for JSON users. We still handle the legacy keys, don't worry 😉.#10000