Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate LoadMetricInformation with double properties #141

Merged

Conversation

gobradovic
Copy link
Contributor

@gobradovic gobradovic commented Nov 7, 2024

The following properties changed type because they
were previously incorrectly defined in the swagger spec:

balancingThreshold: int -> double
activityThreshold: int -> string
currentClusterLoad: int -> double
clusterCapacityRemaining: int -> double
nodeBufferPercentage: int -> double
bufferedClusterCapacityRemaining: int -> double
clusterRemainingBufferedCapacity: int -> string
minimumNodeLoad: int -> double
maximumNodeLoad: int -> double
plannedLoadRemoval: int -> double

Property type change is in principle a breaking change. However,
previous version increment from 4.12.0 to 5.0.0 did not fix all
problems so it was not usable. In that sense, this is considered
a bugfix rather than a new major version (6.0.0).

Property type change is in principle a breaking change. However,
previous version increment from 4.12.0 to 5.0.0 did not fix all
problems so it was not usable. In that sense, this is considered
a bugfix rather than a new major version (6.0.0).
@gobradovic gobradovic enabled auto-merge (squash) November 9, 2024 00:42
@gobradovic gobradovic merged commit 85416aa into develop Nov 9, 2024
2 checks passed
@gobradovic gobradovic deleted the user/gobradovic/LoadMetricInformationChangeDataTypes branch November 9, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants